Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the default gvmd socket path #162

Merged
merged 3 commits into from
Sep 26, 2019

Conversation

y0urself
Copy link
Member

This should be the path to the unix socket in normal circumstances. But it must not be correct (as gvmd uses the CMAKE_INSTALL_PREFIX in the path to the socket ...)

Checklist:

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          12       12           
  Lines        1015     1015           
=======================================
  Hits          927      927           
  Misses         88       88
Impacted Files Coverage Δ
gvm/connections.py 56.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca760e...97a8462. Read the comment docs.

@bjoernricks
Copy link
Contributor

Please add a changelog entry in the Changed category like

  • Changed the default unix domain socket path to /var/run/gvmd.sock

@bjoernricks bjoernricks merged commit afab5f3 into greenbone:master Sep 26, 2019
@y0urself y0urself deleted the default_unix_socket_path branch January 10, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants