Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gmpv9 improvements #165

Merged
merged 12 commits into from
Oct 16, 2019
Merged

Gmpv9 improvements #165

merged 12 commits into from
Oct 16, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Oct 15, 2019 •
edited
Loading

Checklist:

@bjoernricks
Fix returning responses from Gmpv8
dd82eac 
Fix create_task, create_config, create_policy and create_audit methods
of Gmpv9 to return the responses.
@bjoernricks
Drop copy argument from create_tls_certificate
eaebcf5 
It should not be possible to clone a tls certificate currently. If we
support this use case in future it should be moved in an extra
clone_tls_certificate command.
@bjoernricks
Import all type classes into the gmpv9 module
d87aea2 
Allow to import all types from gvm.protocol.gmpv9.
@bjoernricks
Fix docstring for create_tls_certificate method in Gmpv9
20805ed
@bjoernricks
Update some docstring formatting in Gmpv9
484edcd
@bjoernricks
Update using UsageType enum
2e08119 
Remove disabling the pylint warning. And always use the imported
UsageType name.
@bjoernricks
Update create_tls_certificate test for removed copy argument
9f49cef
@bjoernricks
Add gmpv9 to the docs
7a75f3c
@bjoernricks bjoernricks requested a review from wiegandm October 15, 2019 13:03
@bjoernricks bjoernricks marked this pull request as ready for review October 15, 2019 13:04
@codecov
Copy link

codecov bot commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #165 into master will decrease coverage by 0.07%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   91.33%   91.25%   -0.08%     
==========================================
  Files          12       12              
  Lines        1015     1018       +3     
==========================================
+ Hits          927      929       +2     
- Misses         88       89       +1
Impacted Files Coverage Δ
gvm/protocols/latest.py 100% <100%> (ø) ⬆️
gvm/protocols/gmp.py 96.87% <75%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe1e9a...63a9e62. Read the comment docs.

@bjoernricks bjoernricks merged commit 2f01677 into greenbone:master Oct 16, 2019
@bjoernricks bjoernricks deleted the gmpv9-improvements branch October 16, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @wiegandm