Additional tests and api adjustments #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems gvmd is not blocking the cve and gmv/slave scanner types.
Only require scanner_id, allow port to be an int, allow all four types as scanner_type
Require resource_id or resource_type if the other argument is set.
Improve formatting and use ints for start and end arguments
Use consistent naming for test methods
The hosts_ordering argument isn't interpreted by gvmd...
The parameter is not documented in the protocol spec but interpreted by gvmd.
gvmd seems to not require inheritor_id or inheritor_name. Also it is possible to delete a user by id or name.
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 88.01% 91.32% +3.31%
==========================================
Files 10 10
Lines 2377 2374 -3
==========================================
+ Hits 2092 2168 +76
+ Misses 285 206 -79
Continue to review full report at Codecov.
|
wiegandm
requested changes
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only two commands are still missing with this PR: