Change: Revert "Change: Temporarily disable --hard-encoding-detection due to an issue in codespell 2.2.4" #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
… due to an issue in codespell 2.2.4"
cfi-gb
force-pushed
the
revert-518-disable_codespell_chardet_usage
branch
from
ff6cb58 to
e357066
Compare
n-thumann
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reverts #518
Why
Now that Codespell 2.2.5 has been released which includes the fix from codespell-project/codespell#2785 we should revert the previous workaround from our side again and use the
chardetoption to detect the encoding.References
Closes VTD-1940