-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(startup): save startup time, thanks @rem, closes #40 #42
Conversation
I think this is already taken care of/this change doesn't make any difference. |
I could measure ~70ms time improvement consistently on my MBP |
I just wanted to add, except for the time it takes to load the library itself into memory. But this also means the notifier is only ever called when the command doesn't fail, which isn't that cool, given that a lot of fails could result from the CLI being outdated. |
good point, ignore. |
Addendum II: The defaults operation could be quite expensive. We could probably speed this up by just picking name and version first, and then applying the defaults. |
Thanks @remy!