Fix matrix build #389
Merged
Fix matrix build #389
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greenlion please review |
dmnlk
force-pushed
the
feature/php84
branch
2 times, most recently
from
19ea8b6
to
77def14
Compare
|
Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to support PHP 8.4, we discovered that the matrix build is not functioning properly.
I have added an option to PHPUnit to detect deprecated warnings based on the PHP version, and we are failing the CI with a warning. As a result, the CI is currently failing for PHP 8.4.
This pull request does not include fixes for PHP 8.4.
The fix for this issue will be addressed in a separate pull request.
During this process, we also found that the version of PHPUnit specified in composer.json only works with PHP 7.3 and later. Since PHP 7.x has already reached EOL, it should be removed from the supported versions, and PHP 8.x and later should be made mandatory.
This pull request does not include fixes for PHP 8.4.
https://github.com/dmnlk/PHP-SQL-Parser/actions/runs/12015495627