Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-5434: Add PHP 8.1 job #1858

Merged
merged 4 commits into from
Dec 12, 2022
Merged

PLANET-5434: Add PHP 8.1 job #1858

merged 4 commits into from
Dec 12, 2022

Conversation

lithrel
Copy link
Contributor

@lithrel lithrel commented Dec 7, 2022 •
edited
Loading

Ref: https://jira.greenpeace.org/browse/PLANET-5434

Adding a PHP8.1 job to this repo to ensure everything runs on this PHP version.

Fixes

  • Hide deprecated error from WPCS using -d error_reporting option
  • Remove coverage option
    • Coverage doesn't seem to work here, coverage driver is not included
  • Update Timber package to a version supporting php8
  • Removal of phpunit-markup-assertions
    • package is still not updated, but we can replicate its function by directly using laminas package directly and porting this code
    • this code will eventually be removed when/if we switch to Cypress based tests
  • Various PHP fixes
    • undefined constant warning, array_map using pass by reference function, return signature, uninitialized wp_styles

@lithrel lithrel self-assigned this Dec 7, 2022
@lithrel
PLANET-5434: Add PHP8.1 job
cb157b2 
Ref: https://jira.greenpeace.org/browse/PLANET-5434

Add php8.1 job
Hide deprecated error coming from WPCS
Remove unused coverage option
@lithrel
Fix packages issues
88a725c 
Remove outdated package phpunit-markup-assertions
Replace with laminas dependency and copy of used Trait
Update timber to 1.22
@lithrel
Fix tests issues
04d61d4 
Fix array_map warnings
Exclude erroneous sniffs
Fix undefined constant
Fix functions signatures
Fix wp_styles not being initialized in some situations
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 7, 2022
@planet-4
greenpeace/planet4-master-theme#1858 at 04d61d4b
6d19f7b 
/unhold 01c51b4c-2cb2-4e15-9299-bf397c80d40a
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 7, 2022
@planet-4
greenpeace/planet4-master-theme#1858 at 04d61d4b
9d2e940 
/unhold 05bbe426-b7c8-4d0b-9d5a-5d402b0f7293
@planet-4
Copy link
Contributor

planet-4 commented Dec 7, 2022 •
edited
Loading

Test instance is ready 🚀

🌑 titan | admin | blocks report | CircleCI | composer-local.json

⌚ 2022.12.07 21:22:01

@lithrel
Fix array reset
f4835ef 
Fix for acceptance tests failing
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 7, 2022
@planet-4
greenpeace/planet4-master-theme#1858 at f4835ef0
4b56a8b 
/unhold 6f0238d3-2782-4fb8-9802-1deb86c4e8ab
@lithrel lithrel marked this pull request as ready for review December 8, 2022 08:08
@lithrel lithrel requested a review from comzeradd December 8, 2022 08:08
comzeradd
comzeradd approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@comzeradd comzeradd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@lithrel lithrel merged commit d948532 into main Dec 12, 2022
@lithrel lithrel deleted the php8.1 branch December 12, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comzeradd comzeradd comzeradd approved these changes

Assignees

@lithrel lithrel

Labels
[Test Env] titan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lithrel @planet-4 @comzeradd