Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-4924 Re-enable the native buttons block #251

Merged
merged 2 commits into from
Apr 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions admin/js/editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ wp.domReady(() => {
name: 'donate',
label: 'Donate'
});
wp.blocks.unregisterBlockStyle('core/button', 'default');
wp.blocks.unregisterBlockStyle('core/button', 'outline');
wp.blocks.unregisterBlockStyle('core/button', 'squared');
wp.blocks.unregisterBlockStyle('core/button', 'fill');
});
23 changes: 22 additions & 1 deletion assets/src/BlockFilters.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
const { addFilter } = wp.hooks;

import P4ButtonEdit from './components/p4_button/edit';

export const addBlockFilters = () => {
addFileBlockFilter();
addButtonBlockFilter();
};


const addFileBlockFilter = () => {
const setDownloadButtonToggleDefualtFalse = (settings, name) => {

Expand All @@ -20,3 +21,23 @@ const addFileBlockFilter = () => {

addFilter('blocks.registerBlockType', 'planet4-blocks/filters/file', setDownloadButtonToggleDefualtFalse);
};

const addButtonBlockFilter = () => {

const updateButtonBlockEditMethod = (settings, name) => {

if ('core/button' !== name) {
return settings;
}

if ( settings.name === 'core/button' ) {
lodash.assign( settings, {
edit: P4ButtonEdit,
} );
}

return settings;
};

addFilter('blocks.registerBlockType', 'planet4-blocks/filters/button', updateButtonBlockEditMethod);
};
298 changes: 298 additions & 0 deletions assets/src/components/p4_button/edit.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,298 @@
/**
* This file is copy of core button block edit.js (https://github.com/WordPress/gutenberg/blob/7dd6c58c3c6e17c85423fff7a666eab29d749689/packages/block-library/src/button/edit.js), with customize changes.
* Customize changes(PLANET-4924) :
* - Added `p4_button_text_colors` and `p4_button_bg_colors` custom P4 button colors.
* - Remove the BorderPanel control(button borderRadius).
*/

/**
* External dependencies
*/
import classnames from 'classnames';

/**
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';
import { useCallback, useState } from '@wordpress/element';
import { compose } from '@wordpress/compose';
import {
KeyboardShortcuts,
PanelBody,
RangeControl,
TextControl,
ToggleControl,
withFallbackStyles,
ToolbarButton,
ToolbarGroup,
Popover,
} from '@wordpress/components';
import {
BlockControls,
__experimentalUseGradient,
ContrastChecker,
InspectorControls,
__experimentalPanelColorGradientSettings as PanelColorGradientSettings,
RichText,
withColors,
__experimentalLinkControl as LinkControl,
} from '@wordpress/block-editor';
import { rawShortcut, displayShortcut } from '@wordpress/keycodes';
import { link } from '@wordpress/icons';

const { getComputedStyle } = window;

const p4_button_text_colors = [
{ name: 'dark-shade-black', color: '#1a1a1a' },
{ name: 'white', color: '#ffffff' },
];

const p4_button_bg_colors = [
{ name: 'orange', color: '#f36d3a' },
{ name: 'aquamarine', color: '#68dfde' },
{ name: 'white', color: '#ffffff' },
];

const applyFallbackStyles = withFallbackStyles( ( node, ownProps ) => {
const { textColor, backgroundColor } = ownProps;
const backgroundColorValue = backgroundColor && backgroundColor.color;
const textColorValue = textColor && textColor.color;
//avoid the use of querySelector if textColor color is known and verify if node is available.
const textNode =
! textColorValue && node
? node.querySelector( '[contenteditable="true"]' )
: null;
return {
fallbackBackgroundColor:
backgroundColorValue || ! node
? undefined
: getComputedStyle( node ).backgroundColor,
fallbackTextColor:
textColorValue || ! textNode
? undefined
: getComputedStyle( textNode ).color,
};
} );

const NEW_TAB_REL = 'noreferrer noopener';
const MIN_BORDER_RADIUS_VALUE = 0;
const MAX_BORDER_RADIUS_VALUE = 50;
const INITIAL_BORDER_RADIUS_POSITION = 5;

function BorderPanel( { borderRadius = '', setAttributes } ) {
const setBorderRadius = useCallback(
( newBorderRadius ) => {
setAttributes( { borderRadius: newBorderRadius } );
},
[ setAttributes ]
);
return (
<PanelBody title={ __( 'Border settings' ) }>
<RangeControl
value={ borderRadius }
label={ __( 'Border radius' ) }
min={ MIN_BORDER_RADIUS_VALUE }
max={ MAX_BORDER_RADIUS_VALUE }
initialPosition={ INITIAL_BORDER_RADIUS_POSITION }
allowReset
onChange={ setBorderRadius }
/>
</PanelBody>
);
}

function URLPicker( {
isSelected,
url,
setAttributes,
opensInNewTab,
onToggleOpenInNewTab,
} ) {
const [ isURLPickerOpen, setIsURLPickerOpen ] = useState( false );
const openLinkControl = () => {
setIsURLPickerOpen( true );
};
const linkControl = isURLPickerOpen && (
<Popover
position="bottom center"
onClose={ () => setIsURLPickerOpen( false ) }
>
<LinkControl
className="wp-block-navigation-link__inline-link-input"
value={ { url, opensInNewTab } }
onChange={ ( {
url: newURL = '',
opensInNewTab: newOpensInNewTab,
} ) => {
setAttributes( { url: newURL } );

if ( opensInNewTab !== newOpensInNewTab ) {
onToggleOpenInNewTab( newOpensInNewTab );
}
} }
/>
</Popover>
);
return (
<>
<BlockControls>
<ToolbarGroup>
<ToolbarButton
name="link"
icon="admin-links"
title={ __( 'Link' ) }
shortcut={ displayShortcut.primary( 'k' ) }
onClick={ openLinkControl }
/>
</ToolbarGroup>
</BlockControls>
{ isSelected && (
<KeyboardShortcuts
bindGlobal
shortcuts={ {
[ rawShortcut.primary( 'k' ) ]: openLinkControl,
} }
/>
) }
{ linkControl }
</>
);
}

function ButtonEdit( {
attributes,
backgroundColor,
textColor,
setBackgroundColor,
setTextColor,
fallbackBackgroundColor,
fallbackTextColor,
setAttributes,
className,
isSelected,
} ) {
const {
borderRadius,
linkTarget,
placeholder,
rel,
text,
url,
} = attributes;
const onSetLinkRel = useCallback(
( value ) => {
setAttributes( { rel: value } );
},
[ setAttributes ]
);

const onToggleOpenInNewTab = useCallback(
( value ) => {
const newLinkTarget = value ? '_blank' : undefined;

let updatedRel = rel;
if ( newLinkTarget && ! rel ) {
updatedRel = NEW_TAB_REL;
} else if ( ! newLinkTarget && rel === NEW_TAB_REL ) {
updatedRel = undefined;
}

setAttributes( {
linkTarget: newLinkTarget,
rel: updatedRel,
} );
},
[ rel, setAttributes ]
);
const {
gradientClass,
gradientValue,
setGradient,
} = __experimentalUseGradient();

return (
<div className={ className }>
<RichText
placeholder={ placeholder || __( 'Add text…' ) }
value={ text }
onChange={ ( value ) => setAttributes( { text: value } ) }
withoutInteractiveFormatting
className={ classnames( 'wp-block-button__link', {
'has-background': backgroundColor.color || gradientValue,
[ backgroundColor.class ]:
! gradientValue && backgroundColor.class,
'has-text-color': textColor.color,
[ textColor.class ]: textColor.class,
[ gradientClass ]: gradientClass,
'no-border-radius': borderRadius === 0,
} ) }
style={ {
...( ! backgroundColor.color && gradientValue
? { background: gradientValue }
: { backgroundColor: backgroundColor.color } ),
color: textColor.color,
borderRadius: borderRadius
? borderRadius + 'px'
: undefined,
} }
/>
<URLPicker
url={ url }
setAttributes={ setAttributes }
isSelected={ isSelected }
opensInNewTab={ linkTarget === '_blank' }
onToggleOpenInNewTab={ onToggleOpenInNewTab }
/>
<InspectorControls>
<PanelColorGradientSettings
title={ __( 'Background & Text Color' ) }
settings={ [
{
colors: p4_button_text_colors,
colorValue: textColor.color,
onColorChange: setTextColor,
label: __( 'Text color' ),
},
{
colors: p4_button_bg_colors,
colorValue: backgroundColor.color,
onColorChange: setBackgroundColor,
gradientValue,
onGradientChange: setGradient,
label: __( 'Background' ),
},
] }
>
<ContrastChecker
{ ...{
// Text is considered large if font size is greater or equal to 18pt or 24px,
// currently that's not the case for button.
isLargeText: false,
textColor: textColor.color,
backgroundColor: backgroundColor.color,
fallbackBackgroundColor,
fallbackTextColor,
} }
/>
</PanelColorGradientSettings>
<PanelBody title={ __( 'Link settings' ) }>
<ToggleControl
label={ __( 'Open in new tab' ) }
onChange={ onToggleOpenInNewTab }
checked={ linkTarget === '_blank' }
/>
<TextControl
label={ __( 'Link rel' ) }
value={ rel || '' }
onChange={ onSetLinkRel }
/>
</PanelBody>
</InspectorControls>
</div>
);
}

export default compose( [
withColors( 'backgroundColor', { textColor: 'color' } ),
applyFallbackStyles,
] )( ButtonEdit );
6 changes: 5 additions & 1 deletion classes/class-loader.php
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ public function enqueue_editor_scripts( $hook ) {
'wp-i18n', // - Exports the __() function
'wp-editor',
],
'0.1.13',
'0.1.14',
true
);

Expand Down Expand Up @@ -570,6 +570,10 @@ public function set_color_palette() {

// Disable custom color option.
add_theme_support( 'disable-custom-colors' );

// Disable gradient presets & custom gradients.
add_theme_support( 'editor-gradient-presets', [] );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Here I disabled the gradient presets & custom gradients globally.

add_theme_support( 'disable-custom-gradients' );
}

/**
Expand Down
2 changes: 1 addition & 1 deletion planet4-gutenberg-blocks.php
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ function set_allowed_block_types( $allowed_block_types, $post ) {
'core/table', // TODO: Styling.
// 'core/pullquote', // removed, normal quote element is available.
// 'core/verse', // removed, not needed, not styled.
'core/button', // TODO: Styling.
'core/buttons', // TODO: Styling.
// 'core/media-text' // removed, not needed.
// 'core/more', // removed, not needed.
// 'core/nextpage', // removed, not needed.
Expand Down