This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Allow pass column to plcontainer_apply #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuebinsu
reviewed
Dec 27, 2023
greenplumpython/func.py
Outdated
Comment on lines
122
to
126
| "*" | ||
| if ( | ||
| len(input_args) == 0 | ||
| or (len(input_args) == 1 and isinstance(input_args[0], DataFrame)) | ||
| ) |
There was a problem hiding this comment.
We might not need to support those cases. I think the else branch is general enough.
When length is 0, we'd better raise an exception to disallow it, since in this case no data will be retrieved. This is probably not what user would expect.
There was a problem hiding this comment.
Got it, will change it to exception
xuebinsu
approved these changes
Dec 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to pass specific columns when using
plcontainer_apply.