Cleanup some clang-tidy warnings.

examples/hmap/matt.cpp

@@ -14,16 +14,15 @@
 class Timer
 {
 public:
-    Timer(std::string name)
+    Timer(const std::string& name)
         : _name(name)
         , _start(std::chrono::high_resolution_clock::now())
     {
     }
 
     ~Timer()
     {
-        std::chrono::duration<float> elapsed_seconds =
-            std::chrono::high_resolution_clock::now() - _start;
+        std::chrono::duration<float> elapsed_seconds = std::chrono::high_resolution_clock::now() - _start;
         printf("%s: %.3fs\n", _name.c_str(), elapsed_seconds.count());
     }
 
@@ -57,18 +56,15 @@ class RSU
         m_intermediateOffset = permuteQPR(permuteQPR(seedOffset) + 0x46790905);
     }
 
-    uint32_t next()
-    {
-        return permuteQPR((permuteQPR(m_index++) + m_intermediateOffset) ^ 0x5bf03635);
-    }
+    uint32_t next() { return permuteQPR((permuteQPR(m_index++) + m_intermediateOffset) ^ 0x5bf03635); }
 };
 
 using Perturb = std::function<void(std::vector<uint64_t>&)>;
 
 // --------------------------------------------------------------------------
 // --------------------------------------------------------------------------
 template<class Set, size_t N>
-void test(const char* name, Perturb perturb1, Perturb /* perturb2 */)
+void test(const char* name, const Perturb& perturb1, const Perturb& /* perturb2 */)
 {
     // gtl::btree_set<uint64_t> s;
     Set s;
@@ -79,11 +75,11 @@ void test(const char* name, Perturb perturb1, Perturb /* perturb2 */)
     for (uint32_t i = 0; i < N; ++i)
         s.insert(rsu.next());
 
-    std::vector<uint64_t> order(
-        s.begin(), s.end()); // contains sorted, randomly generated keys (when using gtl::btree_set)
-                             // or keys in the final order of a Set (when using Set).
+    std::vector<uint64_t> order(s.begin(),
+                                s.end()); // contains sorted, randomly generated keys (when using gtl::btree_set)
+                                          // or keys in the final order of a Set (when using Set).
 
-    perturb1(order); // either keep them in same order, or shuffle them
+    perturb1(order);                      // either keep them in same order, or shuffle them
 
 #if 0
     order.resize(N/4);

examples/hmap/serialize.cpp

@@ -48,15 +48,12 @@ class RSU
         m_intermediateOffset = permuteQPR(permuteQPR(seedOffset) + 0x46790905);
     }
 
-    unsigned int next()
-    {
-        return permuteQPR((permuteQPR(m_index++) + m_intermediateOffset) ^ 0x5bf03635);
-    }
+    unsigned int next() { return permuteQPR((permuteQPR(m_index++) + m_intermediateOffset) ^ 0x5bf03635); }
 };
 
 // --------------------------------------------------------------------------
 // --------------------------------------------------------------------------
-void showtime(const char* name, std::function<void()> doit)
+void showtime(const char* name, const std::function<void()>& doit)
 {
     auto t1 = std::chrono::high_resolution_clock::now();
     doit();

examples/memoize/mt_memoize.cpp

@@ -46,18 +46,18 @@ int main()
     double                           sum = 0;
     std::vector<std::future<double>> threads;
     gtl::stopwatch<std::milli>       sw;
+    constexpr size_t                 num_threads = 100;
 
-    for (int i = 0; i < 100; i++) {
+    threads.reserve(num_threads);
+    for (int i = 0; i < num_threads; i++) {
         threads.emplace_back(std::async(simulate)); // new thread
     }
 
     for (auto& t : threads) {
         sum += t.get(); // sum results from all threads
     }
 
-    printf("Computed sum = %.3f (expected 24999981374.176) in  %10.3f seconds\n",
-           sum,
-           sw.since_start() / 1000);
+    printf("Computed sum = %.3f (expected 24999981374.176) in  %10.3f seconds\n", sum, sw.since_start() / 1000);
 
     return 0;
 }

examples/memoize/mt_memoize_lru.cpp

@@ -48,18 +48,18 @@ int main()
     double                           sum = 0;
     std::vector<std::future<double>> threads;
     gtl::stopwatch<std::milli>       sw;
+    constexpr size_t                 num_threads = 100;
 
-    for (int i = 0; i < 100; i++) {
+    threads.reserve(num_threads);
+    for (int i = 0; i < num_threads; i++) {
         threads.emplace_back(std::async(simulate)); // new thread
     }
 
     for (auto& t : threads) {
         sum += t.get(); // sum results from all threads
     }
 
-    printf("Computed sum = %.3f (expected 24999981374.176) in  %10.3f seconds\n",
-           sum,
-           sw.since_start() / 1000);
+    printf("Computed sum = %.3f (expected 24999981374.176) in  %10.3f seconds\n", sum, sw.since_start() / 1000);
 
     return 0;
 }

examples/misc/intrusive.cpp

@@ -23,11 +23,9 @@ int main()
 {
     {
         gtl::intrusive_ptr<A> a = new A;
-        ;
 
         {
-            auto                  a2 = a;
-            gtl::intrusive_ptr<D> d  = new D;
+            gtl::intrusive_ptr<D> d = new D;
             {
                 gtl::intrusive_ptr<A> d2 = d;
             }

examples/phmap/mt_word_counter.cpp

@@ -48,6 +48,7 @@ int main()
 
     // run 4 threads, each thread processing lines from one of the vectors
     // -------------------------------------------------------------------
+    threads.reserve(num_threads);
     for (int i = 0; i < num_threads; ++i) {
         threads.emplace_back(
             [&word_counts](std::vector<std::string>&& lines) {

include/gtl/phmap.hpp

@@ -1454,7 +1454,7 @@ class raw_hash_set
         // `that` must be left valid. If Hash is std::function<Key>, moving it
         // would create a nullptr functor that cannot be called.
         // -------------------------------------------------------------------
-        settings_(that.settings_)
+        settings_(std::move(that.settings_))
     {
         // growth_left was copied above, reset the one from `that`.
         that.growth_left() = 0;