Fixed Visual Studio compiler warning #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"#pragma GCC" causes warning 4068 "Unknown pragma" when compiling with Visual Studio 2022.
Maybe the condition should be
#if defined(__GNUC__) || defined(__clang__)
instead. Both are used in the other files.
|
Thanks for the fix @jrade . Please use the following instead, and I'll merge your PR.
|
Replaced
#if defined(__GNUC__)
by
#if defined(__GNUC__) || defined(__clang__)
jrade
force-pushed
the
pragma-warning
branch
from
c4ccc0e to
cc04c56
Compare
|
Done. /Johan
…On Tue, Nov 26, 2024 at 5:21 PM Gregory Popovitch ***@***.***> wrote:
Thanks for the fix @jrade <https://github.com/jrade> . Please use the
following instead, and I'll merge your PR.
#if defined(__GNUC__) || defined(__clang__)
—
Reply to this email directly, view it on GitHub
<#30 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARBZCZBV5VVSKZ457UQ7GL2CSNXDAVCNFSM6AAAAABSQYD326VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRGMYDANJVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The file bits.hpp contains code like
#if defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpedantic"
#endif
Is that correct? Or should it be
#if defined(__GNUC__) || defined(__clang__)
there too? (I only use Visual Studio so I have no idea.)
/Johan
…On Tue, Nov 26, 2024 at 9:02 PM Gregory Popovitch ***@***.***> wrote:
Merged #30 <#30> into main.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARBZC4WPWIIEAVH7RDOEQT2CTHUBAVCNFSM6AAAAABSQYD326VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGQ2DCNJWHA3DOOI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hum, it wouldn't hurt to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"#pragma GCC" causes warning 4068 "Unknown pragma" when compiling with Visual Studio 2022. Maybe the condition should be
#if defined(GNUC) || defined(clang)
instead. Both are used in the other files.