Avoid Memory Reallocations in flat_hash_map clear for Trivial Classes

[linjiahao962889027]

Description:
When both the Key and Value types are trivial classes, I suggest modifying the behavior of clear in flat_hash_map to avoid releasing memory, similar to the behavior of std::vector. The current reallocation during clear impacts performance due to the second allocation, especially for trivial types where memory deallocation isn't necessary. This change would align the behavior with other standard containers, providing better performance for scenarios where frequent clearing is required.

[greg7mdp]

Thanks @linjiahao962889027, this is a good suggestion, I'll look into it.

[greg7mdp]

Hey @linjiahao962889027 , this should fix your issue, please let me know if you see any problem.

[linjiahao962889027]

Hey @linjiahao962889027 , this should fix your issue, please let me know if you see any problem.
Awesome!!! It seems very great!!!

[stdpain]

thanks it resolve my issue

       │                                                                                                                                             ▒
       │     ~__shared_count() noexcept                                                                                                              ▒
       │     {                                                                                                                                       ▒
       │     if (_M_pi != nullptr)                                                                                                                   ▒
  0.13 │       mov     0xa0(%rdi),%rdi                                                                                                               ▒
       │       test    %rdi,%rdi                                                                                                                     ▒
  0.28 │     ↓ je      23                                                                                                                            ▒
       │     _M_pi->_M_release();                                                                                                                    ▒
       │     → call    std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release                                                                 ▒
       │     phmap::priv::raw_hash_set<phmap::priv::FlatHashMapPolicy<int, unsigned long>, starrocks::StdHash<int>, phmap::EqualTo<int>, std::allocat▒
       │     be/build_Release/src/runtime/be/src/util/phmap/phmap.h:1839                                                                             ▒
 69.11 │ 23:   cmpq    $0x0,0x70(%rbx)                                                                                                               ▒
  0.67 │     ↓ je      3f                                                                                                                            ▒
       │     be/build_Release/src/runtime/be/src/util/phmap/phmap.h:1848                                                                             ▒
  0.34 │       mov     0x58(%rbx),%rdi                                                                                                               ▒
  0.02 │       lea     phmap::priv::EmptyGroup()::empty_group,%rax                                                                                   ▒
  0.12 │       cmp     %rax,%rdi                                                                                                                     ▒
       │     ↓ je      3f      

[greg7mdp]

thanks it resolve my issue

Excellent, thanks for letting me know!