Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(babel-preset): fix 'role' attribute on svg element for react native #787

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

slavikdenis
Copy link
Contributor

@slavikdenis slavikdenis commented Oct 12, 2022

Summary

Fixes 'role' attribute introduced in #750 for react-native

Test plan

Upon generation for native, instead of web specific role="img" attribute, there should be the react-native equivalent accessibilityRole="image".

@vercel
Copy link

vercel bot commented Oct 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svgr ❌ Failed (Inspect) Oct 12, 2022 at 2:49PM (UTC)

@slavikdenis
Copy link
Contributor Author

Hi @gregberge

Seems like you have to update node version in Vercel.
Thanks

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants