feat(babel-preset): add attribute role="img" to the svg element #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sinchang
force-pushed
the
feature/add-attribute-role
branch
from
44ba678
to
f335e8b
Compare
Codecov Report
@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 32 32
Lines 802 802
Branches 262 262
=======================================
Hits 740 740
Misses 59 59
Partials 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Thanks @sinchang |
|
I realized this PR doesn't play well with |
|
I have the same issue as @jupavavi @gregberge. |
|
Shall we report this issue? |
|
Fixing it via #787 |
This was referenced Oct 22, 2022
gregberge
pushed a commit
that referenced
this pull request
Oct 27, 2022
This reverts commit 8b9edc4.
gregberge
added a commit
that referenced
this pull request
Oct 27, 2022
docs(a11y): revert #750 and add accessibility documentation for `svgProps` override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #737
Test plan