feat: upgrade to Babel v7 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Sep 3, 2018
package.json
Outdated
| "@babel/core": "^7.0.0", | ||
| "@babel/node": "^7.0.0", | ||
| "@babel/plugin-proposal-class-properties": "^7.0.0", | ||
| "@babel/plugin-proposal-object-rest-spread": "^7.0.0", |
There was a problem hiding this comment.
You don't need object-rest-spread plugin with env preset anymore. It's builtin as part of the spec.
TrySound
reviewed
Sep 3, 2018
packages/rollup/package.json
Outdated
| "@babel/preset-env": "^7.0.0-rc.1", | ||
| "@babel/preset-react": "^7.0.0-rc.1", | ||
| "@babel/core": "^7.0.0", | ||
| "@babel/plugin-proposal-object-rest-spread": "^7.0.0", |
packages/webpack/package.json
Outdated
| "@babel/preset-env": "^7.0.0-rc.1", | ||
| "@babel/preset-react": "^7.0.0-rc.1", | ||
| "@babel/core": "^7.0.0", | ||
| "@babel/plugin-proposal-object-rest-spread": "^7.0.0", |
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
- Coverage 88.76% 88.73% -0.03%
==========================================
Files 26 26
Lines 436 435 -1
Branches 83 79 -4
==========================================
- Hits 387 386 -1
- Misses 45 47 +2
+ Partials 4 2 -2
Continue to review full report at Codecov.
|
|
Why package-lock.json is in the repo? |
TrySound
reviewed
Sep 3, 2018
| "@babel/plugin-proposal-class-properties", | ||
| "@babel/plugin-proposal-object-rest-spread" | ||
| ] | ||
| "plugins": ["@babel/plugin-proposal-class-properties"] |
|
@TrySound thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.