Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHANGELOG.md warning for missing releases, link to Github page #697

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

bradenneufeld
Copy link
Contributor

Summary

As CHANGELOG.md does not contain all major releases and breaking changes (ie. it is missing 6.0.0), the text "All notable changes to this project will be documented in this file" has been causing confusion - it has been removed (as it is not accurate) and a warning has been added to check Github releases.

Test plan

No functional code changes.

As CHANGELOG.md does not contain all major releases and breaking changes, the text "All notable changes to this project will be documented in this file" has been removed (as it is not accurate) and a warning has been added to check Github releases.
@vercel
Copy link

vercel bot commented Mar 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gregberge/svgr/hH7fjdmYb1t3GY6vaowF3QAMAGFy
✅ Preview: https://svgr-git-fork-bradenneufeld-add-changelog-warning-gregberge.vercel.app

@bradenneufeld bradenneufeld changed the title Add changelog warning Add CHANGELOG.md warning for missing releases, link to Github page Mar 8, 2022
@gregberge gregberge merged commit 846d24f into gregberge:main Mar 9, 2022
@gregberge
Copy link
Owner

Thanks @bradenneufeld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants