Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bump svgo to v3.0.2 #798

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Conversation

AndresPuglia98
Copy link
Contributor

@AndresPuglia98 AndresPuglia98 commented Nov 16, 2022

Summary

  • Upgrades svgo to v3.0.2 in packages/plugin-svgo.
  • Removes deprecated @types/svgo in packages/core.
  • Fixes TypeScript issue after upgrading svgo.
  • Updates snapshots

Fixes:

Related:

Test plan

Run:

npm i
npm run build
npm run test

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
svgr ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 9:50PM (UTC)

@AndresPuglia98 AndresPuglia98 changed the title fix: bump svgo to v3.0.1 Fix: bump svgo to v3.0.1 Nov 16, 2022
@gregberge
Copy link
Owner

@AndresPuglia98 thanks for that, tests are failing, could you fix them please?

@AndresPuglia98 AndresPuglia98 changed the title Fix: bump svgo to v3.0.1 Fix: bump svgo to v3.0.2 Nov 23, 2022
@AndresPuglia98
Copy link
Contributor Author

@AndresPuglia98 thanks for that, tests are failing, could you fix them please?

Hey @gregberge, sure. Fixed in 95cd93f.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #798 (c4a6ba0) into main (290748b) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head c4a6ba0 differs from pull request most recent head cea7a69. Consider uploading reports for the commit cea7a69 to get more accurate results

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   93.02%   92.89%   -0.14%     
==========================================
  Files          32       32              
  Lines         746      746              
  Branches      247      247              
==========================================
- Hits          694      693       -1     
- Misses         51       52       +1     
  Partials        1        1              
Impacted Files Coverage Δ
packages/core/src/config.ts 100.00% <ø> (ø)
packages/plugin-svgo/src/index.ts 85.71% <0.00%> (-14.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahkhanjani
Copy link

Hello. Please consider merging this as code coverage is the only test that has failed for this.

@AndresPuglia98
Copy link
Contributor Author

Hi @gregberge, the linter is failing but it passes on my machine.

@gregberge gregberge merged commit 21b6209 into gregberge:main Mar 24, 2023
ruchernchong added a commit to ruchernchong/portfolio that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants