Fix JSX Options Being Ignored In Babel Transpiling #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @beeequeue, could you please fix the tests? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An improvement of #748, this PR fixes the issue that the JSX transform options are not used when using babel to transpile the output. The old PR added a duplicate option for it, this one reuses the existing JSX options.
It's really ugly and duplicates a bunch of code, but I wasn't sure where to put the shared code so I'll let you edit it to whatever you want.
I also updated the
resolvePluginfunction to handle modules that don't just export a single default export.Test plan
I ran this command after linking the built packages to my repo:
and got the response
false.fixes #801