Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of code 3563 is wrong #4

Open
genintho opened this issue Aug 13, 2014 · 5 comments
Open

Description of code 3563 is wrong #4

genintho opened this issue Aug 13, 2014 · 5 comments

Comments

@genintho
Copy link

JOURNEY’S END MOTLS

=> motels

@greggles
Copy link
Owner

Yeah, so there are probably a lot of problems like this. My goal is that the edited description contain fixes like this and also to make things capitalized properly (e.g. "Journey's End Motels").

Are you using the data enough to justify making edits like that?

I think I'd like to do change #3 before this change, tag it as a 1.0, and then start on editing the edited descriptions. Perhaps the first "edit" could be a bulk modification that takes all of the items that are in ALLCAPS and moves them to title case.

@genintho
Copy link
Author

The UI of my app ( https://www.expensify.com/ ) has place that show the mcc code, and its description to the user.
screen shot 2014-08-12 at 6 11 15 pm

So having a nice, meaningful, accurate description has a lot of value. I am happy to help for this project.

@greggles
Copy link
Owner

Awesome! BTW, I added Expensify to the credits in the README :)

Yeah, I'd say that dropping "Nightclubs and Discotheques" from 5813 would also help the readability and layout of that page.

Do you want to provide a PR to fix several of these?

@genintho
Copy link
Author

I will.
But I think working with the json format is more convenient because we can see and discuss each change / description.

@greggles
Copy link
Owner

Hmmm, ok. I was using CSV as the main format since I can easily turn that into xls and ods. I guess starting with json, converting it to csv and then converting that to xls and ods works too.

I care that people contributing the updated descriptions are doing so to one file, but don't have a strong preference that the one file be csv over json. If you prefer editing json then let's make that the main place people should edit. I'm happy to take care of adding a script to convert json to csv and updating the README file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants