Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify column headings, remove spaces #3

Closed
greggles opened this issue Jul 16, 2014 · 7 comments
Closed

simplify column headings, remove spaces #3

greggles opened this issue Jul 16, 2014 · 7 comments

Comments

@greggles
Copy link
Owner

I just used the json formatted data for the first time and realized the "column" headings in the csv are not great as json array keys - they are long which makes the data bigger than necessary and they have some spaces, both of which makes code handling them look odd.

I propose cutting them down as follows:

  • Derived MCC - mcc
  • Edited description - edited_description
  • Combined Description - combined_description
  • USDA Description - usda_description
  • IRS Description - irs_description
  • Reportable under 6041/6041A and Authority for Exception - irs_reportable

Then the README.txt should be updated to describe each field in more detail.

@genintho any thoughts on that idea?

@jbro-io
Copy link

jbro-io commented Jul 17, 2014

👍
You could even cut description down to desc if you wanted to further shorten the length.

@greggles
Copy link
Owner Author

Thanks for the feedback, @jbroquist! I want to make it as short as possible, but still clearly legible as words. desc is a common shortening of description, but I have a slight preference for full words.

@genintho
Copy link

I am happy to see that the json format is used by others 😄

I think it is a good change. I personally reformat the json to something more compact ( keeping only 1 description and remove the irs_reportable field ), but that's for the need of my application which is very specific.

@greggles
Copy link
Owner Author

I assume people use edited description, but if you aren't that would be helpful to know.

The Edited description is the only field that seems very relevant to me beyond the mcc. I imagine the irs_reportable field is useful to some people so I think its reasonable to keep it. Maybe edited description could be shortened to just description since it's intended to be the most modern/friendly description.

@jbro-io
Copy link

jbro-io commented Jul 18, 2014

I've found having all sources are quite useful, especially when trying to determine the source of the Edited Description... The only thing that could make this more useful in my opinion is having the SIC/NAICS code that corresponds with the given MCC codes.

@genintho
Copy link

I think keep all the fields we have now is making sense.

Thanks to JSON it is very easy to consume and transform by people, if they need to. So I am 100% in favor of the changes your mentioned in your first post.

@greggles
Copy link
Owner Author

Okey doke. I think that commit addresses this issue and the feedback you've provided.

Thanks for your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants