MathJax changes to support MathJax 3 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than generating script tags, this now simply wraps suitable delimiters around the maths, which MathJax will then find. This is essentially because I could not work out how to make the script tags work with MatJax 3. In fact I can't work out how the script tags ever worked: there doesn't seem to be any mention of embedding maths this way even for MathJax 2: all the focus is on using delimiters which MathJax looks for. In both MathJax 2 and 3 this makes the output look nicer: using the script approach seems to result in maths which, unless you apply additional styling, is blue, while this approach results in maths which is just ordinary. This change - only changes the output when using MathJax; - makes the output simpler in that case; - makes the formatted output better-looking I think; - works with at least MathJax 2 as well as 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way that MathJax is generated to make things work with MathJax 3 This is the second PR associated with greghendershott/frog#252
Rather than generating script tags, this now simply wraps suitable delimiters around the maths, which MathJax will then find. This is essentially because I could not work out how to make the script tags work with MathJax 3.
In fact I can't work out how the script tags ever worked: there doesn't seem to be any mention of embedding maths this way even for MathJax 2: all the focus is on using delimiters which MathJax looks for. So this would seem to make things a lot closer to how the MathJax people expect things to work, which think is a good thing.
In both MathJax 2 and 3 this makes the output look better: using the script approach seems to result in maths which, unless you apply additional styling, is blue, while this approach results in maths which is just ordinary.
This change
I'm willing to handle any problems which result from this PR.