Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow app:pref_editLayout #182

Open
wants to merge 7 commits into
base: androidx
Choose a base branch
from
Open

Conversation

Mygod
Copy link
Contributor

@Mygod Mygod commented Sep 9, 2018

This allows for implementing an EditTextPreference as in Android 9.0's Wi-Fi AP configuration.

(also I find default value 5 to be nonsensical)

Fixes #181.

This allows for implementing an EditTextPreference as in Android 9.0's Wi-Fi AP configuration.
@gregkorossy
Copy link
Owner

Instead of putting those attributes into the XML, they should be contained in the class, like this (maybe at the end of the constructor?):

getEditText().setTypeface(Typeface.MONOSPACE);
getEditText().setImeOptions(EditorInfoCompat.IME_FLAG_FORCE_ASCII);

@Mygod
Copy link
Contributor Author

Mygod commented Sep 12, 2018 via email

@Mygod Mygod changed the title Use passwordSubstituteLength for password trigger Copy layout params from oldEditText Sep 13, 2018
@Mygod
Copy link
Contributor Author

Mygod commented Sep 13, 2018

@Gericop Please review again. :)

@Mygod
Copy link
Contributor Author

Mygod commented Sep 13, 2018

This PR has been updated according to my idea as per #181.

@Mygod Mygod changed the title Copy layout params from oldEditText Allow app:pref_editLayout Sep 13, 2018
@gregkorossy
Copy link
Owner

I'll release 1.0.0 now and add this later because it messes with the AutoSummaryEditTextPreference (it crashes now since getEditText() returns null).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants