-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow app:pref_editLayout #182
Open
Mygod
wants to merge
7
commits into
gregkorossy:androidx
Choose a base branch
from
Mygod:androidx
base: androidx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for implementing an EditTextPreference as in Android 9.0's Wi-Fi AP configuration.
Instead of putting those attributes into the XML, they should be contained in the class, like this (maybe at the end of the constructor?): getEditText().setTypeface(Typeface.MONOSPACE);
getEditText().setImeOptions(EditorInfoCompat.IME_FLAG_FORCE_ASCII); |
I prefer to do it this way so that user can have control over its style.
|
This reverts commit d1da320.
Mygod
changed the title
Use passwordSubstituteLength for password trigger
Copy layout params from oldEditText
Sep 13, 2018
@Gericop Please review again. :) |
This PR has been updated according to my idea as per #181. |
I'll release 1.0.0 now and add this later because it messes with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for implementing an EditTextPreference as in Android 9.0's Wi-Fi AP configuration.(also I find default value 5 to be nonsensical)Fixes #181.