Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 937 array and custom update filter support #1067

Merged

Conversation

gabrielliwerant
Copy link
Collaborator

@gabrielliwerant gabrielliwerant commented Nov 17, 2019

Closes #937.

  • Add support for array of values in custom filter list rendering, so as to support custom multiselect workflows
  • Add custom update for custom filter list rendering, as this is needed to support the feature
  • Create new API for custom filter list options and deprecate the old API

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 76.66% when pulling 77e80d3 on feature/issue-937-array-and-cusotm-update-filter-support into 2d37c38 on master.

@gabrielliwerant gabrielliwerant merged commit 4f9f2a4 into master Nov 21, 2019
@gabrielliwerant gabrielliwerant deleted the feature/issue-937-array-and-cusotm-update-filter-support branch November 21, 2019 23:33
pgoforth added a commit to pgoforth/mui-datatables that referenced this pull request Nov 25, 2019
…/activeIcon-for-search-not-reset-on-toggle

* 'master' of github.com:gregnb/mui-datatables:
  2.13.0
  Prettify files
  Feature/issue 1036 fixed header (gregnb#1071)
  Update webpack dev server and related dependencies (gregnb#1069)
  Feature/issue 871 (setCellHeaderProps) and Feature/issue 714 (setTableProps) (gregnb#889)
  Feature/issue 937 array and custom update filter support (gregnb#1067)
  Bugfix/issue 1052 csv download issues (gregnb#1064)
  Hide toggle button when the row is not expandable (gregnb#1025)
  add test case to verify reset type (gregnb#1006)
  Update .gitignore and adding yarn.lock (gregnb#1004)
  Serverside sorting example (gregnb#986)
  No Pointer style cursor for table head when no hint or sorting (gregnb#910)
  Added disableToolbarSelect option (gregnb#874)
  Add table properties option (gregnb#670)
@BjoernRave
Copy link

is there an example of the usage somewhere?

@gabrielliwerant
Copy link
Collaborator Author

gabrielliwerant commented Nov 26, 2019

@BjoernRave Yes, customize-filter was updated to use the new API.

lalong13 pushed a commit to lalong13/mui-datatables that referenced this pull request Jan 15, 2020
* Add ability for custom filter list render to use arrays

* Update example to demonstrate new feature

* Rename arguments for clarity

* Add prop type check and deprecation notice

* Allow default filter update when not specified in options

* Fix deprecation warnings in examples

* Improve deprecation verbage for responsive option

* Prettify files

* Update serverside filter list render to include new feature

* Update documentation

* Update tests with deprecation notices and future API

* Add test for custom filter update function call

* Pretiffy test file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Chips are getting concatenated in filterType 'custom' mode, incompatible with multi-select.
3 participants