Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix columns option display PropTypes #1581

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Fix columns option display PropTypes #1581

merged 1 commit into from
Dec 10, 2020

Conversation

wdh2100
Copy link
Collaborator

@wdh2100 wdh2100 commented Nov 13, 2020 •
edited
Loading

  • Add types boolean (true,false)

#1576

Name Type Default
display boolean or string

Fix columns option display PropsTypes
438c379 
 - Add types boolean (true,false)
@wdh2100 wdh2100 added the bug label Nov 13, 2020
@wdh2100 wdh2100 linked an issue Nov 13, 2020 that may be closed by this pull request
Columns display to false throwing console errors #1576
Closed
@lounsbrough
Copy link
Contributor

Can we get this PR merged? It would be great to eliminate errors from our app.

lounsbrough
lounsbrough approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@lounsbrough lounsbrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wdh2100
Copy link
Collaborator Author

wdh2100 commented Dec 10, 2020

@lounsbrough

thanks review,
I will be merging within this week.

@wdh2100 wdh2100 merged commit 56740b4 into master Dec 10, 2020
@wdh2100 wdh2100 deleted the bugfix/display_propsTypes_wrong branch December 10, 2020 08:48
@wdh2100
Copy link
Collaborator Author

wdh2100 commented Dec 10, 2020

@lounsbrough

Fixed 3.7.2

@lounsbrough
Copy link
Contributor

Awesome, thanks!

@wdh2100 wdh2100 mentioned this pull request Dec 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lounsbrough lounsbrough lounsbrough approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Columns display to false throwing console errors
2 participants
@wdh2100 @lounsbrough