Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing episemi bridges #1216

Closed
eroux opened this issue Sep 6, 2016 · 6 comments
Closed

missing episemi bridges #1216

eroux opened this issue Sep 6, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@eroux
Copy link
Contributor

eroux commented Sep 6, 2016

The following MWE:

\documentclass[12pt, a5paper]{book}
\usepackage{libertine}
\usepackage[autocompile]{gregoriotex}
\begin{document}
\gabcsnippet{(c4) no(ghF_E_D_g_e_!/f_g)bis(f.) (;) men.(f_e_!/0hv_hs!hs) (::)}
\end{document}

gives the result

buggregorio1

in which two vertical episemi bridges are missing

@eroux eroux added this to the 5.0 milestone Sep 6, 2016
@henryso
Copy link
Contributor

henryso commented Sep 7, 2016

The first break is because the bridge breaks across elements (i.e., the bridge currently only crosses glyphs). Should the punctum-inclinatum-to-something-else transition continue break the element (and thus the bridge be modified to cross elements) or should the transition be modified to only break the glyph?

The second break is because the code is not bridging across for the half space, so that fix is clear.

@eroux
Copy link
Contributor Author

eroux commented Sep 7, 2016

Well, to be honest I'm not entirely sure what's the best behavior here... There should be a way to make a bridge, but I'm not sure if gregorio should make one by default and then the user should break it if necessary, or if in these cases the current behavior is ok and there should be a _7 to force a bridge... maybe the first solution is the best one?

@henryso
Copy link
Contributor

henryso commented Sep 7, 2016

The simpler solution is to extend the bridge across elements by default(but not across syllables) and let the user break the episema if necessary (i.e., with !). However, it is possible, though more complex (both in the code and in the gabc syntax), to break the bridge through elements by default with a user override to force the bridge.

@henryso
Copy link
Contributor

henryso commented Sep 8, 2016

After debugging further, I was wrong about the cause of the second issue. After the element thing is fixed, it will affect the first issue as well.

As implemented for #401 (comment), bridging across a space will only occur if the ambitus is less than 3. Re-reading the comment, it does specify "top notes", and the check is only from one note to the next. Although this behavior has been in place for a year and a half, should I make the change anyway?

(edited)

henryso added a commit to henryso/gregorio that referenced this issue Sep 8, 2016
@henryso
Copy link
Contributor

henryso commented Sep 8, 2016

After debugging even further, I think this ambitus fix is pretty clean, so I'll create a pull request. If you agree with the change, please review and merge.

@eroux
Copy link
Contributor Author

eroux commented Sep 8, 2016

merged, thanks a lot!

@henryso henryso closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants