-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing episemi bridges #1216
Comments
The first break is because the bridge breaks across elements (i.e., the bridge currently only crosses glyphs). Should the punctum-inclinatum-to-something-else transition continue break the element (and thus the bridge be modified to cross elements) or should the transition be modified to only break the glyph? The second break is because the code is not bridging across for the half space, so that fix is clear. |
Well, to be honest I'm not entirely sure what's the best behavior here... There should be a way to make a bridge, but I'm not sure if gregorio should make one by default and then the user should break it if necessary, or if in these cases the current behavior is ok and there should be a |
The simpler solution is to extend the bridge across elements by default(but not across syllables) and let the user break the episema if necessary (i.e., with |
After debugging further, I was wrong about the cause of the second issue. After the element thing is fixed, it will affect the first issue as well. As implemented for #401 (comment), bridging across a space will only occur if the ambitus is less than 3. Re-reading the comment, it does specify "top notes", and the check is only from one note to the next. Although this behavior has been in place for a year and a half, should I make the change anyway? (edited) |
After debugging even further, I think this ambitus fix is pretty clean, so I'll create a pull request. If you agree with the change, please review and merge. |
merged, thanks a lot! |
The following MWE:
gives the result
in which two vertical episemi bridges are missing
The text was updated successfully, but these errors were encountered: