Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gabc-version header #664

Closed
rpspringuel opened this issue Oct 30, 2015 · 5 comments
Closed

gabc-version header #664

rpspringuel opened this issue Oct 30, 2015 · 5 comments
Assignees
@henryso
Labels
C
Milestone
4.0

Comments

@rpspringuel
Copy link
Contributor

If the command line tool is put into verbose mode when compiling a gabc file, it raises an error about the gabc-version header if it is not 0.9.3. Either, the command line tool should be updated so that it checks the version number against the current version number (and VersionManager.py changed to keep it up to date) or the gabc-version header should be deprecated.
@rpspringuel rpspringuel added this to the 4.0 milestone Oct 30, 2015
@henryso
Copy link
Contributor

henryso commented Oct 30, 2015

I don't know if gabc-version is the version of the "gabc specification" or if it's the version of Gregorio. Can anyone make a sensible decision on this?

@rpspringuel
Copy link
Contributor Author

My impression was that we had decided that they were all one and the same now.

Additionally, we've made some modifications that involved changes in the gabc entry, so even if the above isn't true, we still need to update that number.

@rpspringuel
Copy link
Contributor Author

Hmm... Checking the issue history, it looks like this wasn't addressed in #87 as I thought it was. So, discuss.

I think that having a separate version number is cumbersome and not really necessary. (And that's all I have time to say right now.)

@henryso
Copy link
Contributor

henryso commented Oct 30, 2015

I honestly have no opinion at all. I was actually asking for guidance as to what to do to fix it.

@eroux
Copy link
Contributor

eroux commented Oct 31, 2015

Originally there was supposed to be different versions of gabc and gregorio could have compiled them differently, but that's not going to happen, so maybe the best would be to deprecate gabc-version?

@henryso henryso self-assigned this Oct 31, 2015
@henryso henryso added the C label Oct 31, 2015
henryso added a commit to henryso/gregorio that referenced this issue Oct 31, 2015
@henryso
Deprecated the gabc-version header.
d5a58b0 
Fixes gregorio-project#664.
henryso added a commit to henryso/gregorio that referenced this issue Oct 31, 2015
@henryso
Deprecated the gabc-version header.
0ac783f 
Fixes gregorio-project#664.
@henryso henryso mentioned this issue Oct 31, 2015
Merged
@henryso henryso closed this as completed Nov 1, 2015
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Nov 2, 2015
@rpspringuel
Merge commit '38aca71f66d829ddefe3c29108cc3423db9ea1a3' into document…
4e4934c 
…ation

* commit '38aca71f66d829ddefe3c29108cc3423db9ea1a3':
  16 new glyphs for nabc notation, small fixes.
  Deprecated the gabc-version header. Fixes gregorio-project#664.
  Fixed lost "endgroup" for first letter centering of empty syllables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryso henryso

Labels
C
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@eroux @henryso @rpspringuel