Protect filenames #1426
Protect filenames #1426
Conversation
I've created a function for protecting file names (substituting `-` for a bunch of invalid characters) and used it to protect snippet related files. This prevents projects which have these characters in the main project file's name from not finding the executable (gregorio-project#1416).
|
Just realized that I haven't created a test for this issue. I'll work on that later today. |
|
Problem with creating a possible test. Adding a single quote to a file name raises the following error from the testing script: @henryso do you have any suggestions for how we might deal with this in the script? |
|
I've been thinking about this and since the problem is in trying to mix this unusual filename with |
|
Perhaps the harness can be rewritten to use the null separator so that |
|
I think I've figured out a way to make this work. However, I think it will require a change to the viewer settings in gregorio-test.rc. Also, it'll take a bit more doing before I'm done. |
|
I have something that works, but I'd like to wait for #1429 to be merged so that it's easier to make the changes I need to make to |
|
On second thought, looks like I'd need to get this against the ctan branch. I'll try to rework it tomorrow. |
|
I slept on it and decided I could just bring the changes in wholesale. @rpspringuel Please try your tests with this code, and merge gregorio-project/gregorio-test#328 if it is satisfactory or provide feedback for me to fix. |
This fix for problematic filenames seems to work and is simpler than what I was working on in gregorio-project#1426. It is compatible with gregorio-project/gregorio-test#328 after the changes I proposed on henryso/gregorio-test#1 are pulled in. The corresponding PR which adds the test for this problem is gregorio-project/gregorio-test#331
|
This PR is getting a bit difficult for me to follow, but I think as long as the tests work (which they seem to do) and this change works on Windows as well, then we're good to go ahead with it. |
|
OK, I'll put my comment there. |
I've created a function for protecting file names (substituting
-for a bunch of invalid characters) and used it to protect snippet related files. This prevents projects which have these characters in the main project file's name from not finding the executable (#1416).