Implemented a toggle-able forced hyphen for empty initial syllables. #656
Conversation
Corresponds with gregorio-project/gregorio#656. Tests the fix for gregorio-project/gregorio#653.
|
|
||
| ### Empty first syllable hyphen | ||
|
|
||
| Prior to version 4.0, GregorioTeX would put a hyphen below an empty first syllable (which happens when the first syllable consists only of the initial). The spacing algorithm was improved in 4.0, but that eliminates the hyphen if there is not enough space between the note of the first syllable and the next syllable. The `\gresetemptyfirstsyllablehyphen` command controls this behavior. It defaults to `force`, which restores the pre-4.0 behavior, but may be changed to `auto` (i.e., `\gresetemptyfirstsyllablehyphen{auto}`) if you prefer the space-based behavior. |
There was a problem hiding this comment.
Maybe it would be best to document this for 4.0, as it it where the change happened? Thinking about that again, I'm wondering if it's a good idea not to do this hyphen thing for 4.0... what do you think (again)?
There was a problem hiding this comment.
I'm a little confused by your statement. Are you saying that we should do this change in 4.0 or leave it here in develop? If you think the scope of these changes is not "too much" for this late in the 4.0 cycle, then I can reopen the pull request against release-4.0.
My only concern with doing it this late in 4.0 is code quality. Of course, programmers never think they write buggy code, but experience often proves otherwise...
If this is not what you mean, can you clarify?
There was a problem hiding this comment.
That's what I mean indeed, I'm just concerned by this change in 4.0 that might not be easily spotted by users but would "damage" their scores...
|
Apart from the commentary, it looks good |
|
I will re-open against release-4.0. |
* develop: Addeds test and expectations for note-in-same-glyph episema height fix. Tests the fix for gregorio-project/gregorio#693. Updated expectations to match the fix for gregorio-project/gregorio#675. Added gabc-to-gabc tests and expectations. Added support for gabc-to-gabc tests. Updated expectations to match changes for gregorio-project/gregorio#670. Updated test for biginitial style deprecation. Corresponds with changes for gregorio-project/gregorio#632. Updated tests and expectations for initial-style deprecation. Corresponds with changes for gregorio-project/gregorio#632. Added support for per-gabc-output-test preamble files. Updated expectations to match changes for gregorio-project/gregorio#632. Added a test for the forced initial hyphen. Corresponds with gregorio-project/gregorio#656. Tests the fix for gregorio-project/gregorio#653. Added tests and expectations corresponding to gregorio-project/gregorio#636. This tests the implementation of gregorio-project/gregorio#631.
Fixes #653.
Please review and merge if satisfactory.