Update so we can use this on rails 5 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanhealy
reviewed
Jul 19, 2018
| @@ -114,7 +114,11 @@ def initialize(object, method, template_object, default_schedules = nil, options | |||
| end | |||
|
|
|||
| def render | |||
| option_tags = add_options(recurring_options_for_select(value(object), @default_schedules, @options), @options, value(object)) | |||
| if Rails::VERSION::STRING >= '5.2' | |||
There was a problem hiding this comment.
Just wanted to confirm if this is this specific to Rails 5.2+ or should we make this 5+?
There was a problem hiding this comment.
Looks like rails 5.2 uses the object directly!
activerecord-hackery/ransack#853
|
looks good to me |
This was referenced Jul 20, 2018
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's get this working with rails 5! 🎉
References