Pass errors from MITM SSL sockets up to the proxy object #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes socket errors from the SSL MITM code path up to the the top level Proxy object so they may be handled externally.
Without this fix, I was seeing
ECONNRESETerrors bubble up as uncaught errors which could only be handled with aprocess.on('uncaughtException', .....)block. I believe the source of these errors is random client disconnects when using hoxy in a cross browser testing environment via selenium.I didn't see an obvious way to introduce tests for this in the current test suite, if I've missed something here please point me in the right direction and I'll add them.