Skip to content

format: retain comments in arrays and records #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 29, 2022
Merged

format: retain comments in arrays and records #160

merged 8 commits into from
Nov 29, 2022

Conversation

avh4
Copy link
Contributor

@avh4 avh4 commented Nov 29, 2022 •
edited
Loading

  • retain comments in array expressions
    • before each item
    • after each item
    • (not included in this PR: in an empty array)
  • retain comments in array patterns
    • before each item
    • after each item
    • (not included in this PR: in an empty array pattern)
  • retain comments in record expressions
    • (for record update) between { and base
    • (for record update) between base and |
    • before each field name
    • between each field name and =
    • between each = and value
    • after each value
    • (not included in this PR: in an empty record)
  • retain comments in record types
    • (for record extension) between { and base
    • (for record extension) between base and |
    • before each field name
    • between each field name and :
    • between each : and field type
    • after each field type
    • (not included in this PR: in an empty record type)
  • (not included in this PR: retain comments in record patterns)

@avh4 avh4 mentioned this pull request Nov 29, 2022
Open
31 tasks
robinheghan
robinheghan approved these changes Nov 29, 2022
View reviewed changes
compiler/src/Parse/Expression.hs
chompArrayEnd start [entry],
do
-- TODO: comments in an empty array are dropped; what to do with these?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will follow up in Zulip about possible options here

@robinheghan robinheghan merged commit 11da5c5 into gren-lang:main Nov 29, 2022
@avh4 avh4 deleted the retain-comments/6-literals branch November 30, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinheghan robinheghan robinheghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avh4 @robinheghan