Lumosviridi v0.30.0 kubernetes updates #21
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| labels: | ||
| app: twentycrm-redis | ||
| name: twentycrm-redis | ||
| namespace: twentycrm | ||
| spec: | ||
| progressDeadlineSeconds: 600 | ||
| replicas: 1 | ||
| strategy: | ||
| rollingUpdate: | ||
| maxSurge: 1 | ||
| maxUnavailable: 1 | ||
| type: RollingUpdate | ||
| selector: | ||
| matchLabels: | ||
| app: twentycrm-redis | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: twentycrm-redis | ||
| spec: | ||
| containers: | ||
| - env: | ||
| - name: PORT | ||
| value: 6379 | ||
| - image: redis/redis-stack-server:latest | ||
|
Comment on lines
+24
to
+28
There was a problem hiding this comment. logic: The configuration defines two separate containers incorrectly. The env section is defined as a separate container from the Redis container. This will cause deployment issues. There was a problem hiding this comment. style: Using 'latest' tag for production deployments is risky - should specify exact version for stability and reproducibility |
||
| imagePullPolicy: Always | ||
| name: redis | ||
| ports: | ||
| - containerPort: 6379 | ||
| name: redis | ||
| protocol: TCP | ||
| resources: | ||
| requests: | ||
| memory: "1024Mi" | ||
| cpu: "250m" | ||
| limits: | ||
| memory: "2048Mi" | ||
| cpu: "500m" | ||
| stdin: true | ||
| tty: true | ||
|
|
||
| dnsPolicy: ClusterFirst | ||
| restartPolicy: Always | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| apiVersion: v1 | ||
| kind: PersistentVolume | ||
| metadata: | ||
| name: twentycrm-docker-data-pv | ||
| spec: | ||
| storageClassName: default | ||
| capacity: | ||
| storage: 10Gi | ||
| accessModes: | ||
| - ReadWriteOnce | ||
| persistentVolumeReclaimPolicy: Retain | ||
|
Comment on lines
+5
to
+11
There was a problem hiding this comment. logic: Missing required storage backend configuration (hostPath, nfs, etc). PV needs to specify where and how the actual storage is provisioned. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| apiVersion: v1 | ||
| kind: PersistentVolumeClaim | ||
| metadata: | ||
| name: twentycrm-docker-data-pvc | ||
| namespace: twentycrm | ||
| spec: | ||
| storageClassName: default | ||
| volumeName: twentycrm-docker-data-pv | ||
|
There was a problem hiding this comment. style: explicitly binding to PV reduces flexibility - consider removing volumeName for dynamic provisioning |
||
| accessModes: | ||
| - ReadWriteOnce | ||
| resources: | ||
| requests: | ||
| storage: 10Gi | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: twentycrm-redis | ||
| namespace: twentycrm | ||
| spec: | ||
| internalTrafficPolicy: Cluster | ||
|
There was a problem hiding this comment. style: internalTrafficPolicy: Cluster is redundant when type is ClusterIP - this is the default behavior |
||
| ports: | ||
| - port: 6379 | ||
| protocol: TCP | ||
| targetPort: 6379 | ||
| selector: | ||
| app: twentycrm-redis | ||
| sessionAffinity: ClientIP | ||
| sessionAffinityConfig: | ||
| clientIP: | ||
| timeoutSeconds: 10800 | ||
|
Comment on lines
+14
to
+17
There was a problem hiding this comment. style: 3-hour session affinity timeout (10800 seconds) may be excessive for Redis connections. Consider reducing to 1-2 hours to prevent stale connections. |
||
| type: ClusterIP | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,12 +15,12 @@ output: | |
| <!-- BEGIN_TF_DOCS --> | ||
| # TwentyCRM Terraform Docs | ||
|
|
||
| This file was generated by [terraform-docs](https://terraform-docs.io/), for more information on how to install, configure, and use visit their website. | ||
|
|
||
| To update this `README.md` after changes to the Terraform code in this folder, run: `terraform-docs -c `./.terraform-docs.yml .` | ||
|
There was a problem hiding this comment. syntax: command includes unnecessary backticks around the path - should be |
||
|
|
||
| To make configuration changes to how this doc is generated, see `./.terraform-docs.yml` | ||
|
|
||
| {{ .Content }} | ||
| <!-- END_TF_DOCS --> | ||
|
|
||
|
|
@@ -45,4 +45,3 @@ settings: | |
| read-comments: true | ||
| required: true | ||
| sensitive: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,64 +1,73 @@ | ||
| <!-- BEGIN_TF_DOCS --> | ||
| # TwentyCRM Terraform Docs | ||
|
|
||
| This file was generated by [terraform-docs](https://terraform-docs.io/), for more information on how to install, configure, and use visit their website. | ||
|
|
||
| To update this `README.md` after changes to the Terraform code in this folder, run: `terraform-docs -c `./.terraform-docs.yml .` | ||
|
|
||
| To make configuration changes to how this doc is generated, see `./.terraform-docs.yml` | ||
|
|
||
| ## Requirements | ||
|
|
||
| | Name | Version | | ||
| |------|---------| | ||
| | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.7.4 | | ||
|
There was a problem hiding this comment. logic: downgrading Terraform version requirement from 1.9.2 to 1.7.4 may introduce compatibility issues with newer features |
||
| | <a name="requirement_kubernetes"></a> [kubernetes](#requirement\_kubernetes) | >= 2.32.0 | | ||
| | <a name="requirement_random"></a> [random](#requirement\_random) | >= 3.6.3 | | ||
|
|
||
| ## Providers | ||
|
|
||
| | Name | Version | | ||
| |------|---------| | ||
| | <a name="provider_kubernetes"></a> [kubernetes](#provider\_kubernetes) | 2.32.0 | | ||
| | <a name="provider_random"></a> [random](#provider\_random) | 3.6.3 | | ||
|
|
||
| ## Resources | ||
|
|
||
| | Name | Type | | ||
| |------|------| | ||
| | [kubernetes_deployment.twentycrm_db](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/deployment) | resource | | ||
| | [kubernetes_deployment.twentycrm_redis](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/deployment) | resource | | ||
| | [kubernetes_deployment.twentycrm_server](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/deployment) | resource | | ||
| | [kubernetes_deployment.twentycrm_worker](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/deployment) | resource | | ||
| | [kubernetes_ingress.twentycrm](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/ingress) | resource | | ||
| | [kubernetes_namespace.twentycrm](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/namespace) | resource | | ||
| | [kubernetes_persistent_volume.db](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/persistent_volume) | resource | | ||
| | [kubernetes_persistent_volume.docker_data](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/persistent_volume) | resource | | ||
| | [kubernetes_persistent_volume.server](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/persistent_volume) | resource | | ||
| | [kubernetes_persistent_volume_claim.db](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/persistent_volume_claim) | resource | | ||
| | [kubernetes_persistent_volume_claim.docker_data](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/persistent_volume_claim) | resource | | ||
| | [kubernetes_persistent_volume_claim.server](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/persistent_volume_claim) | resource | | ||
| | [kubernetes_secret.twentycrm_tokens](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/secret) | resource | | ||
| | [kubernetes_service.twentycrm_db](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/service) | resource | | ||
| | [kubernetes_service.twentycrm_redis](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/service) | resource | | ||
| | [kubernetes_service.twentycrm_server](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/service) | resource | | ||
| | [random_bytes.this](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/bytes) | resource | | ||
|
|
||
| ## Inputs | ||
|
|
||
| | Name | Description | Type | Default | Required | | ||
| |------|-------------|------|---------|:--------:| | ||
| | <a name="input_twentycrm_app_hostname"></a> [twentycrm\_app\_hostname](#input\_twentycrm\_app\_hostname) | The protocol, DNS fully qualified hostname, and port used to access TwentyCRM in your environment. Ex: https://crm.example.com:443 | `string` | n/a | yes | | ||
| | <a name="input_twentycrm_pgdb_admin_password"></a> [twentycrm\_pgdb\_admin\_password](#input\_twentycrm\_pgdb\_admin\_password) | TwentyCRM password for postgres database. | `string` | n/a | yes | | ||
| | <a name="input_twentycrm_app_name"></a> [twentycrm\_app\_name](#input\_twentycrm\_app\_name) | A friendly name prefix to use for every component deployed. | `string` | `"twentycrm"` | no | | ||
| | <a name="input_twentycrm_db_image"></a> [twentycrm\_db\_image](#input\_twentycrm\_db\_image) | TwentyCRM image for database deployment. This defaults to latest. | `string` | `"twentycrm/twenty-postgres:latest"` | no | | ||
| | <a name="input_twentycrm_db_pv_capacity"></a> [twentycrm\_db\_pv\_capacity](#input\_twentycrm\_db\_pv\_capacity) | Storage capacity provisioned for database persistent volume. | `string` | `"10Gi"` | no | | ||
| | <a name="input_twentycrm_db_pv_path"></a> [twentycrm\_db\_pv\_path](#input\_twentycrm\_db\_pv\_path) | Local path to use to store the physical volume if using local storage on nodes. | `string` | `""` | no | | ||
| | <a name="input_twentycrm_db_pvc_requests"></a> [twentycrm\_db\_pvc\_requests](#input\_twentycrm\_db\_pvc\_requests) | Storage capacity reservation for database persistent volume claim. | `string` | `"10Gi"` | no | | ||
| | <a name="input_twentycrm_db_replicas"></a> [twentycrm\_db\_replicas](#input\_twentycrm\_db\_replicas) | Number of replicas for the TwentyCRM database deployment. This defaults to 1. | `number` | `1` | no | | ||
| | <a name="input_twentycrm_docker_data_mount_path"></a> [twentycrm\_docker\_data\_mount\_path](#input\_twentycrm\_docker\_data\_mount\_path) | TwentyCRM mount path for servers application data. Defaults to '/app/docker-data'. | `string` | `"/app/docker-data"` | no | | ||
| | <a name="input_twentycrm_docker_data_pv_capacity"></a> [twentycrm\_docker\_data\_pv\_capacity](#input\_twentycrm\_docker\_data\_pv\_capacity) | Storage capacity provisioned for server persistent volume. | `string` | `"10Gi"` | no | | ||
| | <a name="input_twentycrm_docker_data_pv_path"></a> [twentycrm\_docker\_data\_pv\_path](#input\_twentycrm\_docker\_data\_pv\_path) | Local path to use to store the physical volume if using local storage on nodes. | `string` | `""` | no | | ||
| | <a name="input_twentycrm_docker_data_pvc_requests"></a> [twentycrm\_docker\_data\_pvc\_requests](#input\_twentycrm\_docker\_data\_pvc\_requests) | Storage capacity reservation for server persistent volume claim. | `string` | `"10Gi"` | no | | ||
| | <a name="input_twentycrm_namespace"></a> [twentycrm\_namespace](#input\_twentycrm\_namespace) | Namespace for all TwentyCRM resources | `string` | `"twentycrm"` | no | | ||
| | <a name="input_twentycrm_redis_image"></a> [twentycrm\_redis\_image](#input\_twentycrm\_redis\_image) | TwentyCRM image for Redis deployment. This defaults to latest. | `string` | `"redis/redis-stack-server:latest"` | no | | ||
| | <a name="input_twentycrm_redis_replicas"></a> [twentycrm\_redis\_replicas](#input\_twentycrm\_redis\_replicas) | Number of replicas for the TwentyCRM Redis deployment. This defaults to 1. | `string` | `"1"` | no | | ||
|
There was a problem hiding this comment. logic: twentycrm_redis_replicas should be type |
||
| | <a name="input_twentycrm_server_data_mount_path"></a> [twentycrm\_server\_data\_mount\_path](#input\_twentycrm\_server\_data\_mount\_path) | TwentyCRM mount path for servers application data. Defaults to '/app/packages/twenty-server/.local-storage. | `string` | `"/app/packages/twenty-server/.local-storage"` | no | | ||
|
There was a problem hiding this comment. syntax: description is missing a closing quote after '.local-storage' |
||
| | <a name="input_twentycrm_server_image"></a> [twentycrm\_server\_image](#input\_twentycrm\_server\_image) | TwentyCRM server image for the server deployment. This defaults to latest. This value is also used for the workers image. | `string` | `"twentycrm/twenty:latest"` | no | | ||
| | <a name="input_twentycrm_server_pv_capacity"></a> [twentycrm\_server\_pv\_capacity](#input\_twentycrm\_server\_pv\_capacity) | Storage capacity provisioned for server persistent volume. | `string` | `"10Gi"` | no | | ||
| | <a name="input_twentycrm_server_pv_path"></a> [twentycrm\_server\_pv\_path](#input\_twentycrm\_server\_pv\_path) | Local path to use to store the physical volume if using local storage on nodes. | `string` | `""` | no | | ||
| | <a name="input_twentycrm_server_pvc_requests"></a> [twentycrm\_server\_pvc\_requests](#input\_twentycrm\_server\_pvc\_requests) | Storage capacity reservation for server persistent volume claim. | `string` | `"10Gi"` | no | | ||
| | <a name="input_twentycrm_server_replicas"></a> [twentycrm\_server\_replicas](#input\_twentycrm\_server\_replicas) | Number of replicas for the TwentyCRM server deployment. This defaults to 1. | `number` | `1` | no | | ||
| | <a name="input_twentycrm_worker_replicas"></a> [twentycrm\_worker\_replicas](#input\_twentycrm\_worker\_replicas) | Number of replicas for the TwentyCRM worker deployment. This defaults to 1. | `number` | `1` | no | | ||
| <!-- END_TF_DOCS --> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| resource "kubernetes_deployment" "twentycrm_redis" { | ||
| metadata { | ||
| name = "${var.twentycrm_app_name}-redis" | ||
| namespace = kubernetes_namespace.twentycrm.metadata.0.name | ||
|
|
||
| labels = { | ||
| app = "${var.twentycrm_app_name}-redis" | ||
| } | ||
| } | ||
|
|
||
| spec { | ||
| replicas = var.twentycrm_redis_replicas | ||
|
There was a problem hiding this comment. logic: var.twentycrm_redis_replicas is used but not defined in the variables.tf file shown in the context |
||
| selector { | ||
| match_labels = { | ||
| app = "${var.twentycrm_app_name}-redis" | ||
| } | ||
| } | ||
|
|
||
| strategy { | ||
| type = "RollingUpdate" | ||
| rolling_update { | ||
| max_surge = "1" | ||
| max_unavailable = "1" | ||
| } | ||
| } | ||
|
|
||
| template { | ||
| metadata { | ||
| labels = { | ||
| app = "${var.twentycrm_app_name}-redis" | ||
| } | ||
| } | ||
|
|
||
| spec { | ||
| container { | ||
| image = var.twentycrm_redis_image | ||
|
There was a problem hiding this comment. logic: var.twentycrm_redis_image is used but not defined in the variables.tf file shown in the context |
||
| name = "redis" | ||
| stdin = true | ||
| tty = true | ||
|
Comment on lines
+38
to
+39
There was a problem hiding this comment. style: stdin and tty are set to true but may not be necessary for a Redis container as it typically runs as a daemon |
||
|
|
||
| port { | ||
| container_port = 6379 | ||
| protocol = "TCP" | ||
| } | ||
|
|
||
| resources { | ||
| requests = { | ||
| cpu = "250m" | ||
| memory = "1024Mi" | ||
| } | ||
| limits = { | ||
| cpu = "500m" | ||
| memory = "2048Mi" | ||
| } | ||
| } | ||
|
Comment on lines
+46
to
+55
There was a problem hiding this comment. style: memory requests and limits are quite high for a basic Redis instance - consider reducing unless there's a specific requirement |
||
| } | ||
| dns_policy = "ClusterFirst" | ||
| restart_policy = "Always" | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: The PORT environment variable value should be an integer or string, not an unquoted number