Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blocks/net: Prevent crash of tun block #369

Merged
merged 2 commits into from
Apr 20, 2019
Merged

blocks/net: Prevent crash of tun block #369

merged 2 commits into from
Apr 20, 2019

Conversation

p-hamann
Copy link
Contributor

@p-hamann p-hamann commented Apr 17, 2019 •
edited by atheriel
Loading

Fixes #365.

@atheriel
Copy link
Collaborator

atheriel commented Apr 19, 2019 •
edited
Loading

Not sure about this solution. It seems to be possible for a device to have tun_flags but not be named tun* (e.g. TAP devices).

@p-hamann
Copy link
Contributor Author

Oh, indeed. Fixed it now.

@atheriel atheriel merged commit db9d0e9 into greshake:master Apr 20, 2019
@atheriel
Copy link
Collaborator

Seems like a reasonable solution. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net block stays unresponsive if device path does not exist at startup
2 participants
@p-hamann @atheriel