Server review #7
Conversation
template for express api
add cors, node-fetch, and get search/query
update fetch data
add axios get to serpstack
server full functional
There was a problem hiding this comment.
Great work again guys, me and Ravil were impressed that you used a public API. Super refreshing as we created one so was nice to see someone take a different approach. Works well, we ran the server side with no issues. Although, probably not your fault, but results took a few seconds to return and show on the page. Other than that great job and was a pleasure too look through and try out 👍
| @@ -1 +1,33 @@ | |||
| # Gclone Server | |||
There was a problem hiding this comment.
Great use of README, as mentioned in other repo
| @@ -0,0 +1,15 @@ | |||
| function formatData(data, length){ | |||
| data.length = length | |||
| return data.filter(item => item !== 'undefined') | |||
There was a problem hiding this comment.
Good use of validation!
|
|
||
| function randomData(data){ | ||
| length = data.length | ||
| randomIndex = Math.floor(Math.random() * length) |
There was a problem hiding this comment.
Good use of Math functions
| @@ -0,0 +1,6 @@ | |||
| const server = require("./server"); | |||
| const port = process.env.PORT || 3000 | |||
There was a problem hiding this comment.
Good use of OR rule
| axios.get(url) | ||
| .then(function (response) { | ||
| // formatData(response); | ||
| res.status(200).send({body: helpers.formatData(response.data.organic_results, 10)}) |
There was a problem hiding this comment.
This line could be placed into two lines to make it more readable:
const formated = helpers.formatData(response.data.organic_results, 10) res.status(200).send({body: formated)
| axios.get(url) | ||
| .then(function (response) { | ||
| // formatData(response); | ||
| res.status(200).send({body: helpers.randomData(helpers.formatData(response.data.organic_results, 10))}) | ||
| }) | ||
| .catch(console.warn) |
There was a problem hiding this comment.
Could create a separate function for fetching response passing through as arguments, the url and the function you want to use to format the data. This would reduce duplicate code!
No description provided.