Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support folders under "src/resources" in fastReload configuration property #305

Merged

Conversation

aindlq
Copy link

@aindlq aindlq commented May 9, 2024

When hotreload is enabled, gretty watches and always recompile/redeploy webapp if there are any changes in "src/java" or "src/resources". That is inconvenient when one has many static resources in "src/resources" that don't require recompilation/redeploy.

This change makes sure that fastReload check is performed before recompile check for sources. So as a workaround one can specify such folders under src/resources as fastReload and prevent recompilation/redeploy.

…perty.

When hotreload is enabled gretty watches and always recompile/redeploy webapp if
there are any change "src/java" or "src/resources". That is
inconvenient when changing static resources in "src/resources" that
don't require recompilation/redeploy.

Workaround is to specify such folders under `src/resources` as
fastReload.

This change makes sure that fastReload check is performed before
recompile check for sources.
@boris-petrov boris-petrov requested a review from f4lco May 14, 2024 03:14
@f4lco f4lco changed the title Support folders under "src/resources" in fastReload conifguration property Support folders under "src/resources" in fastReload configuration property May 19, 2024
Copy link
Collaborator

@f4lco f4lco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good commit message / PR description! LGTM and thanks for your contribution 🎉

@f4lco f4lco merged commit 806457e into gretty-gradle-plugin:gretty-3.x May 19, 2024
4 checks passed
f4lco pushed a commit that referenced this pull request May 19, 2024
…perty. (#305)

When hotreload is enabled gretty watches and always recompile/redeploy webapp if
there are any change "src/java" or "src/resources". That is
inconvenient when changing static resources in "src/resources" that
don't require recompilation/redeploy.

Workaround is to specify such folders under `src/resources` as
fastReload.

This change makes sure that fastReload check is performed before
recompile check for sources.
@aindlq aindlq deleted the check-fastreload-first branch May 20, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants