Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ojisan could be seriously. #16

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Ojisan could be seriously. #16

merged 1 commit into from
Jun 1, 2019

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Jun 1, 2019

I fixed error case by '-e 0' .
We can represent ojisan's seriousness by using no emoji.

@greymd
Copy link
Owner

greymd commented Jun 1, 2019

That's great idea ❗😄💯
But a problem of this way is that {EMOJI_ASK} is going to be replaced to the punctuation, that does not mean "question" 😱

On the other hand ✋ 😘❗-e 0 is rarely used 😄😃❗
I believe this is not going to be a big issue 👍 😜
For now, let me merge your suggestion 💪 😍 ❤️
And I (or somebody else) may improve this issue in the future 👍 🏩

@greymd greymd merged commit 42f84af into greymd:master Jun 1, 2019
@Yang-33
Copy link
Contributor Author

Yang-33 commented Jun 1, 2019

Yes! This is not a big issue.
It should have been said in a different way.
Sorry, @greymd 😍 ❤️ ❗
I love your project😘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yang-33 @greymd