26: x_icon null safety compile warning fix #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated icon.dart to add a default case so the section of code with the warnings becomes theoretically reachable, and constructed the style for the returned Text widget in a way that makes the compiler happy.
|
Thanks for the PR. LGTM as far. can you confirm that this compiles & ran fine on your local machine? |
|
Yes, it runs clean on my box. Fixed it first by tweaking the library directly in my project then replicated them in the x_icon repo. |
|
Thanks alot! Merging for now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated icon.dart to add a default case so the section of code with the warnings becomes theoretically reachable, and constructed the style for the returned Text widget in a way that makes the compiler happy.