Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the use of --no-copy flag in out docs #321

Merged
merged 6 commits into from
Jul 20, 2022
Merged

Clarify the use of --no-copy flag in out docs #321

merged 6 commits into from
Jul 20, 2022

Conversation

krishnakalyan3
Copy link
Contributor

krishnakalyan3
krishnakalyan3 commented Jul 18, 2022
View reviewed changes
Copy link
Contributor Author

@krishnakalyan3 krishnakalyan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarify private s3 use

@oojo12 oojo12 requested review from essiequoi and panos-is July 18, 2022 12:31
@essiequoi essiequoi requested a review from rlizzo July 18, 2022 15:18
@krishnakalyan3 krishnakalyan3 requested a review from oojo12 July 18, 2022 16:25
@krishnakalyan3
Copy link
Contributor Author

@oojo12 and @robert-s-lee let me know if this looks better!.

rlizzo
rlizzo approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@rlizzo rlizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds great to me!

@oojo12 oojo12 merged commit afe27c2 into gridai:dev Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlizzo rlizzo rlizzo approved these changes

@oojo12 oojo12 oojo12 approved these changes

@essiequoi essiequoi Awaiting requested review from essiequoi

@panos-is panos-is Awaiting requested review from panos-is

@robert-s-lee robert-s-lee Awaiting requested review from robert-s-lee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krishnakalyan3 @robert-s-lee @rlizzo @oojo12 @panos-is