Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rules and methods for hessian of sum of scalar CellFields and product of two scalar CellFields #1053

Merged
merged 9 commits into from
Mar 10, 2025

Conversation

kishore-nori
Copy link
Collaborator

  • added rules and methods for hessian of sum of scalar Fields (hence CellFields)
  • added rules and methods for hessian of product of two scalar Fields (hence CellFields)
  • added corresponding tests to check the new functionality

this closes issue #875

@kishore-nori kishore-nori linked an issue Nov 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 64.10256% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.37%. Comparing base (a8b5028) to head (a7c046a).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/Fields/ApplyOptimizations.jl 50.00% 11 Missing ⚠️
src/Fields/FieldsInterfaces.jl 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
+ Coverage   89.36%   89.37%   +0.01%     
==========================================
  Files         197      197              
  Lines       23935    23970      +35     
==========================================
+ Hits        21389    21423      +34     
- Misses       2546     2547       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kishore-nori kishore-nori marked this pull request as draft November 17, 2024 14:17
@JordiManyer
Copy link
Member

Hey @kishore-nori ! I need this actually, can we merge it? I think we would only need to pull from master and increase a bit the number of tests.

@JordiManyer
Copy link
Member

Also closes #69

@kishore-nori kishore-nori marked this pull request as ready for review March 10, 2025 22:24
@kishore-nori
Copy link
Collaborator Author

Hi @JordiManyer I have added few more tests, and it improves the codecov but seem like haven't been able to trigger the code additions in src/Fields/ApplyOptimizations.jl. Having said that, it works on CellFields and FEFunctions so should be alright.

@JordiManyer JordiManyer merged commit 6de2594 into master Mar 10, 2025
17 checks passed
@kishore-nori kishore-nori deleted the kn/laplacian-cf-prod branch March 15, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Laplacian of product of CellFields doesn't work.
2 participants