Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constructors for DiracDelta with Triangulation argument. #1087

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

shagun751
Copy link
Contributor

DiracDelta definitions were limited to DiscreteModel{D} argument. Introduced constructors for DiracDelta with Triangulation{Dt} argument.
Added the tests for the same in DiracDeltaTests.jl as well.

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.35%. Comparing base (6db1059) to head (512129b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1087   +/-   ##
=======================================
  Coverage   89.35%   89.35%           
=======================================
  Files         197      197           
  Lines       23916    23935   +19     
=======================================
+ Hits        21370    21388   +18     
- Misses       2546     2547    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JordiManyer
Copy link
Member

Hi @shagun751 , thank you for your contribution! Could you add a new entry to NEWS.md? I will merge your PR after that.
Thank you!

@shagun751
Copy link
Contributor Author

@JordiManyer I have updated NEWS.md as per convention.
Thank you!

@JordiManyer JordiManyer merged commit a8b5028 into gridap:master Mar 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants