Merge pull request #2556 from barton2526/error-codes

rpc: fix invalid parameter error codes for {sign,verify}message RPCs
gridcoin-community · Aug 1, 2022 · afa6b3b · afa6b3b
2 parents 271c0ce + f9f2e2b
commit afa6b3b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -458,7 +458,7 @@ UniValue signmessage(const UniValue& params, bool fHelp)
 
  CBitcoinAddress addr(strAddress);
  if (!addr.IsValid())
- throw JSONRPCError(RPC_TYPE_ERROR, "Invalid address");
+ throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid address");
 
  CKeyID keyID;
  if (!addr.GetKeyID(keyID))
@@ -495,7 +495,7 @@ UniValue verifymessage(const UniValue& params, bool fHelp)
 
  CBitcoinAddress addr(strAddress);
  if (!addr.IsValid())
- throw JSONRPCError(RPC_TYPE_ERROR, "Invalid address");
+ throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid address");
 
  CKeyID keyID;
  if (!addr.GetKeyID(keyID))
@@ -505,7 +505,7 @@ UniValue verifymessage(const UniValue& params, bool fHelp)
  vector<unsigned char> vchSig = DecodeBase64(strSign.c_str(), &fInvalid);
 
  if (fInvalid)
- throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Malformed base64 encoding");
+ throw JSONRPCError(RPC_TYPE_ERROR, "Malformed base64 encoding");
 
  CDataStream ss(SER_GETHASH, 0);
  ss << strMessageMagic;