Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Fix several minor linter errors #2476

Merged
merged 7 commits into from
Mar 27, 2022
Merged

build: Fix several minor linter errors #2476

merged 7 commits into from
Mar 27, 2022

Commits on Mar 27, 2022

  1. Change the name of MRC tests from MRC to mrc_tests to stop linter com… 

    …plaint
    @jamescowens
    jamescowens committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    b9b623c View commit details
    Browse the repository at this point in the history

  2. Add spelling exception to eliminate linter false positive on changelog

    @jamescowens
    jamescowens committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    bbdd83b View commit details
    Browse the repository at this point in the history

  3. Eliminate the linter false positive on double include of QtPlugin in … 

    …bitcoin.cpp
    @jamescowens
    jamescowens committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    71e99a7 View commit details
    Browse the repository at this point in the history

  4. Change tfm::format for no stream version to tfm::strformat 

    The linter is confused by the overload of tfm::format to return
a string instead of the first argument being a stream. Using a
different function name solves the problem.
    @jamescowens
    jamescowens committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    2d87b6a View commit details
    Browse the repository at this point in the history

  5. Add LogPrint exception to lint-format-strings.py to silence linter fa… 

    …lse positive
    @jamescowens
    jamescowens committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    0863ea3 View commit details
    Browse the repository at this point in the history

  6. Fix several LogPrint related variadic warnings from linter

    @jamescowens
    jamescowens committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    02f167e View commit details
    Browse the repository at this point in the history

  7. Fix typo in comment 

    Co-authored-by: RoboticMind <30132912+RoboticMind@users.noreply.github.com>
    @jamescowens @RoboticMind
    jamescowens and RoboticMind authored Mar 27, 2022
    Configuration menu
    Copy the full SHA
    c16b448 View commit details
    Browse the repository at this point in the history