Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voting: Optimize poll locks #2619

Merged
merged 8 commits into from
Feb 2, 2023
Merged

voting: Optimize poll locks #2619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b63d5ec
Instrument buildPollTable
jamescowens Dec 21, 2022
e74cb00
Implement cs_poll_registry locking.
jamescowens Dec 24, 2022
76f86a6
Add missing poll and vote contract reverts from DisconnectBlocksBatch
jamescowens Jan 3, 2023
2e93908
Add documentation for InvalidDuetoReorgFork in getpollresults and vot…
jamescowens Jan 26, 2023
4651af0
Narrow cs_poll_registry locking in getpollresults and votedetails
jamescowens Jan 26, 2023
873863e
Adds std::atomic<bool> g_reorg_in_progress
jamescowens Jan 26, 2023
abd5816
Add checks for existing polls/votes in contract handlers
jamescowens Jan 29, 2023
8441bda
Add registry_traversal_in_progress guard to PollResultToJson
jamescowens Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/gridcoin/contract/contract.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,9 @@ class Dispatcher
{
// Don't reset the beacon registry as it is now backed by a database.
// GetBeaconRegistry().Reset();
GetPollRegistry().Reset();

// Don't reset the poll registry as reorgs are properly handled.
// GetPollRegistry().Reset();
GetWhitelist().Reset();
m_appcache_handler.Reset();
}
Expand Down Expand Up @@ -458,7 +460,7 @@ void GRC::ReplayContracts(CBlockIndex* pindex_end, CBlockIndex* pindex_start)

LogPrint(BCLog::LogFlags::CONTRACT, "Replaying contracts from block %" PRId64 "...", pindex->nHeight);

// This no longer includes beacons.
// This no longer includes beacons or polls.
g_dispatcher.ResetHandlers();

BeaconRegistry& beacons = GetBeaconRegistry();
Expand Down Expand Up @@ -618,6 +620,8 @@ void GRC::ApplyContracts(
}
}

// Note that for polls and votes, this rescan could overlap contracts already recorded. The handlers for polls/votes
// check for the existence of contracts already recorded and will prevent a double application.
g_dispatcher.Apply({ contract, tx, pindex });

// Don't track transaction message contracts in the block index:
Expand Down
Loading