-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-11309 #153
base: ignite-11314
Are you sure you want to change the base?
IGNITE-11309 #153
Conversation
public boolean isAffinityAwareness(); | ||
|
||
/** | ||
* @param affinityAwareness {@code True} if jdbc thin affinity awareness is enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems 'True' should be in lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
* | ||
* @throws Exception If failed. | ||
*/ | ||
@org.junit.Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls use import for org.junit.Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
ps = conn.prepareStatement("select * from Person where _key = ? or _key = ?"); | ||
ps.setInt(1, 1); | ||
ps.setInt(2, 2); | ||
checkNodesUsage(ps, null, 2, 2, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code style - need to add line to separate statements. The same for the whole class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ufff, fixed
"jdbc:ignite:thin://127.0.0.1:10800..10802" : | ||
"jdbc:ignite:thin://127.0.0.1"; | ||
|
||
/** URL with best effort affinity flag. */ | ||
private String urlWithBestEffortAffinityFlag = url + | ||
(affinityAwareness ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be simplified to "?affinityAwareness=" + affinityAwareness;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
PR for review