Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for custom domain overwrite deploy bug #511

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Add fix for custom domain overwrite deploy bug #511

merged 3 commits into from
Feb 12, 2021

Conversation

christianboyle
Copy link
Contributor

If this CNAME record doesn't exist in /static when you run the deploy script the custom domain user setting in GitHub will be reset to https://<username>.github.io.

Bug and fix described here: tschaub/gh-pages#213

If this `CNAME` record doesn't exist in `/static` when you run the `deploy` script the custom domain user setting in GitHub will be reset to `https://<username>.github.io`.

Bug and fix described here: tschaub/gh-pages#213
docs/deploy-to-github.md Outdated Show resolved Hide resolved
@travis-r6s
Copy link
Member

@christianboyle Sorry, my bad - the MD linter wants to have a language tag. I guess you could just add txt?

@christianboyle
Copy link
Contributor Author

christianboyle commented Feb 12, 2021

I was going to try that, but didn't see txt as an option here: https://www.rubycoloredglasses.com/2013/04/languages-supported-by-github-flavored-markdown/

Are any of these more appropriate than js?

Edit: Nevermind, I see txt now, will fix: https://github.com/github/linguist/blob/master/lib/linguist/languages.yml#L5712

@travis-r6s
Copy link
Member

Wow, that's a super long list, and useful for future reference! Thanks

@travis-r6s travis-r6s merged commit ae4ab9f into gridsome:master Feb 12, 2021
@christianboyle christianboyle deleted the patch-1 branch February 12, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants