Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drag item back between 2 grids broke in 2.0.1 #1484

Closed
adumesny opened this issue Nov 27, 2020 · 0 comments
Closed

drag item back between 2 grids broke in 2.0.1 #1484

adumesny opened this issue Nov 27, 2020 · 0 comments

Comments

@adumesny
Copy link
Member

adumesny commented Nov 27, 2020 •
edited
Loading

Your environment

  • gridstack.js 2.0.1
  • chrome

Steps to reproduce

starting with 2.0.1 use https://gridstackjs.com/demo/two.html and drag an item from left into right grid, but don't release and drag it back

--> missing the drop feedback and won't follow the mouse

Expected behaviour

this broke in 2.0.1 (ok in 2.0.0)

regression while fixing #393 in #1383
adumesny added a commit to adumesny/gridstack.js that referenced this issue Nov 27, 2020
@adumesny
fix to drag between 2 grids and back
fe2e173 
* fix for gridstack#1484, introduced in 2.0.1
* make sure we reset _added flag when leaving other grid and we get back
@adumesny adumesny mentioned this issue Nov 27, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adumesny