Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow percentage as a valid unit for height #1093

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Allow percentage as a valid unit for height #1093

merged 2 commits into from
Dec 16, 2019

Conversation

adumesny
Copy link
Member

Description

from #748 which I couldn't merge, plus doc and test case update.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
Allow percentage as a valid unit for height
9013329 
from #748 which I couldn't merge, plus doc and test case update.
@adumesny
fix link
c727a09
@adumesny adumesny mentioned this pull request Dec 16, 2019
Closed
@coveralls
Copy link

coveralls commented Dec 16, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 66.667% when pulling c727a09 on adumesny:develop into 3b8f016 on gridstack:develop.

@adumesny adumesny merged commit 8989dfa into gridstack:develop Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adumesny @coveralls