Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

much faster removeAll(), single event trigger #1097

Merged
merged 2 commits into from
Dec 17, 2019
Merged

much faster removeAll(), single event trigger #1097

merged 2 commits into from
Dec 17, 2019

Conversation

adumesny
Copy link
Member

Description

  • removeAll() is now much faster as it doesn't cause any relayout (added GridStackEngine.removeAll to optimize)
  • it now calls removed event back just once with a list of nodes
  • _removedNodes uses actual nodes (not clones)

better fix than #551, related to previous #1096

Checklist

  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
much faster removeAll(), single event trigger
1c77147 
* `removeAll()` is now much faster as it doesn't cause any relayout (added GridStackEngine.removeAll to optimize)
* it now calls `removed` event back just once with a list of nodes
* _removedNodes uses actualy nodes (not clones)

better fix than #551, related to previous #1096
@adumesny adumesny mentioned this pull request Dec 17, 2019
Closed
@coveralls
Copy link

coveralls commented Dec 17, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 66.703% when pulling f7e46c5 on adumesny:develop into bf28a78 on gridstack:develop.

@adumesny adumesny merged commit 5035a18 into gridstack:develop Dec 17, 2019
@HiroyasuNishiyama HiroyasuNishiyama mentioned this pull request Mar 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adumesny @coveralls