Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed oneColumnModeClass and associated code #1134

Merged
merged 1 commit into from
Feb 5, 2020
Merged

removed oneColumnModeClass and associated code #1134

merged 1 commit into from
Feb 5, 2020

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Feb 5, 2020

Description

  • If you depended on this, use class .grid-stack-1 instead of .grid-stack-one-column-mode since it is 1 column layout anyway
  • updated jasmin test
  • should have been done in OneColumnMode use setColumn(1) #1120

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* If you depended on this, use class `.grid-stack-1` instead of `.grid-stack-one-column-mode` since it is 1 column layout anyway
* updated jasmin test
* should have been done in #1120
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 67.841% when pulling 85bc82e on adumesny:develop into 9e9443b on gridstack:develop.

@adumesny adumesny merged commit f46fbfc into gridstack:develop Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants