Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridStackWidget use w,h,minW,minH #1493

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Conversation

adumesny
Copy link
Member

Description

  • just like the attributes shortening, Grid Item position are now
    x,y,w,h with shorter min/maxW|H
  • this and prev change end up saving 2k on gridstack-h5.js output file!
    (now only 63.2k)
  • hard to change as not simple global replace, as width|height are still
    used in CSS and rect, etc....

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* just like the attributes shortening, Grid Item position are now
x,y,w,h with shorter min/maxW|H
* this and prev change end up saving 2k on gridstack-h5.js output file!
(now only 63.2k)
* hard to change as not simple global replace, as width|height are still
used in CSS and rect, etc....
@adumesny adumesny merged commit 570a55f into gridstack:develop Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant